test: set test-process-finalization as flaky#63057
test: set test-process-finalization as flaky#63057IlyasShabi wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
39f8cde to
3bcacb1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63057 +/- ##
==========================================
- Coverage 89.65% 89.63% -0.02%
==========================================
Files 708 708
Lines 220413 220413
Branches 42275 42280 +5
==========================================
- Hits 197607 197571 -36
- Misses 14658 14704 +46
+ Partials 8148 8138 -10 🚀 New features to boost your workflow:
|
|
@IlyasShabi
Lines 2108 to 2111 in b2f6aa3 That matches the failure here: the child process exits with status 0, but stdout only contains Keeping the registered refs alive until exit should make this deterministic, e.g. by storing the main-thread and worker refs in a module-level array before registering them. The V8 update may still be related, but it seems more likely that it changed GC timing enough to expose this fragile test assumption. |
|
One concrete shape for the fixture fix could be to keep the registered refs alive in a top-level array, for both the main thread and the worker. |
Set
test-process-finalizationas flaky#63056